[webkit-reviews] review granted: [Bug 133528] SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font : [Attachment 232923] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 133528: SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph
in an SVG font
https://bugs.webkit.org/show_bug.cgi?id=133528

Attachment 232923: Patch
https://bugs.webkit.org/attachment.cgi?id=232923&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232923&action=review


> Source/WebCore/platform/graphics/mac/FontMac.mm:548
> +	       // The advances will get all messed up if we do anything other
than bail here.
> +	       result.clear(); // Better to be consistent rather than
half-correct

Maybe make the comments a bit less hilarious.