[webkit-reviews] review granted: [Bug 129448] lldb_webkit.py throws exception when generating summary of null StringImpl : [Attachment 235851] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 31 16:27:19 PDT 2014
Jer Noble <jer.noble at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 129448: lldb_webkit.py throws exception when generating summary of null
StringImpl
https://bugs.webkit.org/show_bug.cgi?id=129448
Attachment 235851: Patch
https://bugs.webkit.org/attachment.cgi?id=235851&action=review
------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235851&action=review
r=me, with nit.
> Tools/lldb/lldb_webkit.py:58
> + return ""
Nit: it might be nice to return "{ null }" here.
More information about the webkit-reviews
mailing list