[webkit-reviews] review granted: [Bug 135471] CodeBlock fails to visit the Executables of its InlineCallFrames : [Attachment 235840] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 135471: CodeBlock fails to visit the Executables of its InlineCallFrames
https://bugs.webkit.org/show_bug.cgi?id=135471

Attachment 235840: Patch
https://bugs.webkit.org/attachment.cgi?id=235840&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235840&action=review


> Source/JavaScriptCore/bytecode/CodeOrigin.h:153
>	       return jsCast<JSFunction*>(calleeRecovery.constant());
>	   return 0;
>      }
> +
> +    void visitAggregate(SlotVisitor& visitor)
> +    {
> +	   visitor.append(&executable);
> +    }

This poor second-class class can probably be a first-class class in its own
header. That way, we provide upward mobility inside our code base.