[webkit-reviews] review granted: [Bug 135207] Web Inspector: InspectorBackend's promise-based agent API does not support multiple return values : [Attachment 235371] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 23 13:44:22 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135207: Web Inspector: InspectorBackend's promise-based agent API does not
support multiple return values
https://bugs.webkit.org/show_bug.cgi?id=135207

Attachment 235371: Patch
https://bugs.webkit.org/attachment.cgi?id=235371&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235371&action=review


Clever. Sounds good for now! r=me

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:377
> +	       // than by setting a magical property on the callback.
<webkit.org/b/132386>

Nit: Include "https://" on that URL.


More information about the webkit-reviews mailing list