[webkit-reviews] review denied: [Bug 134301] Implement parsing for CSS scroll snap points : [Attachment 234998] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 134301: Implement parsing for CSS scroll snap points
https://bugs.webkit.org/show_bug.cgi?id=134301

Attachment 234998: Patch
https://bugs.webkit.org/attachment.cgi?id=234998&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234998&action=review


> Source/WebCore/rendering/style/StyleScrollSnapPoints.h:58
> +    static Length defaultRepeatPoint()
> +    {
> +	   return Length(100, Percent);
> +    }
> +    
> +    static Length defaultDestinationPoint()
> +    {
> +	   return Length(0, Fixed);
> +    }

Not sure I like the names having "point" since these don't use
IntPoint/FloatPoint.

>
LayoutTests/platform/mac/css3/scroll-snap/scroll-snap-property-computed-style-e
xpected.txt:98
> +pixel/pixel destination : 10px 50px
> +PASS
window.getComputedStyle(document.body).getPropertyValue('-webkit-scroll-snap-de
stination') is '10px 50px'

You should test fractional values here as well (10.5px, 12.234px)