[webkit-reviews] review denied: [Bug 134897] Copying and pasting trivial H2 content causes a crash in firstPositionInNode : [Attachment 235073] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 17 12:17:47 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134897: Copying and pasting trivial H2 content causes a crash in
firstPositionInNode
https://bugs.webkit.org/show_bug.cgi?id=134897
Attachment 235073: Patch
https://bugs.webkit.org/attachment.cgi?id=235073&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235073&action=review
> LayoutTests/editing/pasteboard/heading-crash-expected.txt:6
> +| <h2>
> +| id="source"
> +| "Copy This Text<#selection-caret>"
This output is incorrect. We should be stripping the inner h2.
Otherwise, we'd create two h2s next to each other.
So the fix is incorrect.
More information about the webkit-reviews
mailing list