[webkit-reviews] review granted: [Bug 134809] [MSE] Separate MediaSource logging into its own log channel : [Attachment 234765] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 134809: [MSE] Separate MediaSource logging into its own log channel
https://bugs.webkit.org/show_bug.cgi?id=134809

Attachment 234765: Patch
https://bugs.webkit.org/attachment.cgi?id=234765&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234765&action=review


Nice change. Extra points for using "sequester" in the ChangeLog!

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:645
> +	   m_client->sourceBufferPrivateDidReceiveSample(this, mediaSample);

Should be mediaSample.release().