[webkit-reviews] review granted: [Bug 134821] Use a separate backdrop element to allow cues to have highlight and background color : [Attachment 234743] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 134821: Use a separate backdrop element to allow cues to have highlight and
background color
https://bugs.webkit.org/show_bug.cgi?id=134821

Attachment 234743: Patch
https://bugs.webkit.org/attachment.cgi?id=234743&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234743&action=review


It looks like a couple of test results need to be updated.

Thanks!

> Source/WebCore/rendering/RenderVTTCue.cpp:343
> +    // First child is our wrapping <div>. We need to get ITS first child.

Nit: "We need to get ITS" -> "The cue object is the <div>'s"