[webkit-reviews] review granted: [Bug 134500] Add WTF::move() : [Attachment 234284] Patch 1 of 2 - Only adds WTF::move()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 3 09:51:04 PDT 2014


Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 134500: Add WTF::move()
https://bugs.webkit.org/show_bug.cgi?id=134500

Attachment 234284: Patch 1 of 2 - Only adds WTF::move()
https://bugs.webkit.org/attachment.cgi?id=234284&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234284&action=review


> Source/WTF/wtf/StdLibExtras.h:122
> +template<class T>

I prefer typename.

> Source/WTF/wtf/StdLibExtras.h:135
> +   
static_assert(std::is_move_constructible<NonConstNonRefQualifiedType>::value ||
std::is_move_assignable<NonConstNonRefQualifiedType>::value, "T is not
movable.");

I thought we discussed that we want && here, not ||.


More information about the webkit-reviews mailing list