[webkit-reviews] review granted: [Bug 95286] buildAccessibilityTree() needs to be removed from individual layout tests : [Attachment 234349] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 95286: buildAccessibilityTree() needs to be removed from individual layout
tests
https://bugs.webkit.org/show_bug.cgi?id=95286

Attachment 234349: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=234349&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234349&action=review


> LayoutTests/resources/accessibility-helper.js:14
> +    if (accessibilityObject.stringValue.indexOf('End of test') >= 0)

maybe this should be a "stopElement" that you pass into the method. this way is
a bit opaque as to when it would end

> LayoutTests/resources/accessibility-helper.js:27
> +    if (accessibilityObject.stringValue.indexOf('End of test') >= 0)

ditto