[webkit-reviews] review requested: [Bug 127910] Avoid eagerly creating the JSActivation when the debugger is attached : [Attachment 222864] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 31 16:41:51 PST 2014


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 127910: Avoid eagerly creating the JSActivation when the debugger is
attached
https://bugs.webkit.org/show_bug.cgi?id=127910

Attachment 222864: the patch.
https://bugs.webkit.org/attachment.cgi?id=222864&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
This patch has passed all the layout tests with and without debugger bytecode
generated.  I've also done a smoke test of using the WebInspector to step
through some code.

Octane scores for this patch:
	    baseline w/o WebInspector: 11621
	    patched  w/o WebInspector: 11801
	    baseline w/ WebInspector:  3295
	    patched  w/ WebInspector:  7070   2.1x improvement


More information about the webkit-reviews mailing list