[webkit-reviews] review granted: [Bug 127986] Remove inline member functions of FrameSelection that access m_selection : [Attachment 222861] Fix EFL build

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 127986: Remove inline member functions of FrameSelection that access
m_selection
https://bugs.webkit.org/show_bug.cgi?id=127986

Attachment 222861: Fix EFL build
https://bugs.webkit.org/attachment.cgi?id=222861&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222861&action=review


Looks good to me. Please fix FrameSelection.h before landing otherwise it will
break iOS builds.

> Source/WebCore/editing/FrameSelection.h:343
> +    bool m_updateAppearanceEnabled : 1;DragController.cpp

This must be a typo. I'm sure it doesn't build like this for iOS :-)

> Source/WebCore/page/DragController.cpp:816
> +	   const VisibleSelection& srcSelection = src.selection().selection();

I would call it sourceSelection.