[webkit-reviews] review granted: [Bug 128022] Add webView:didFailNavigation:withError: delegate method : [Attachment 222857] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 128022: Add webView:didFailNavigation:withError: delegate method
https://bugs.webkit.org/show_bug.cgi?id=128022

Attachment 222857: Patch
https://bugs.webkit.org/attachment.cgi?id=222857&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222857&action=review


> Source/WebKit2/UIProcess/API/C/WKPage.cpp:743
> +	   virtual void didFailLoadWithErrorForFrame(WebPageProxy* page,
WebFrameProxy* frame, uint64_t navigationID, const ResourceError& error,
API::Object* userData) override

Won’t we get a warning because we are not using navigationID here?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:487
> +    WebDocumentLoader& documentLoader =
static_cast<WebDocumentLoader&>(*m_frame->coreFrame()->loader().documentLoader(
));

Do we have a checked version of this cast? Should we?

Seems like coreFrame should return a reference, not a pointer.