[webkit-reviews] review granted: [Bug 128024] Don't need a JSNameScope for the callee name just for the debugger : [Attachment 222859] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 128024: Don't need a JSNameScope for the callee name just for the debugger
https://bugs.webkit.org/show_bug.cgi?id=128024

Attachment 222859: the patch.
https://bugs.webkit.org/attachment.cgi?id=222859&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222859&action=review


r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   the function name is only needed for evals which can redefined the
name

"redefine"

> Source/JavaScriptCore/ChangeLog:14
> +	   The debugger does not add the need for this functionality. Hence, we
can
> +	   remove the presence of the debugger as a criteria for pushing the

The reason the debugger doesn't need this feature is that it declares all new
vars in a temporary, nested scope.