[webkit-reviews] review denied: [Bug 127908] [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR : [Attachment 222666] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 127908: [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
https://bugs.webkit.org/show_bug.cgi?id=127908

Attachment 222666: patch
https://bugs.webkit.org/attachment.cgi?id=222666&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222666&action=review


The patch looks good to me, but you need to add empty stubs for Mac and iOS
too. More specifically, the missing stubs would go to:

  Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
  Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
  Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1027
> +

Extra line