[webkit-reviews] review granted: [Bug 127876] Extended background should only create margin tiles for pages with background images : [Attachment 222623] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 30 07:22:01 PST 2014
Antti Koivisto <koivisto at iki.fi> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 127876: Extended background should only create margin tiles for pages with
background images
https://bugs.webkit.org/show_bug.cgi?id=127876
Attachment 222623: Patch
https://bugs.webkit.org/attachment.cgi?id=222623&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=222623&action=review
> Source/WebCore/rendering/RenderLayerBacking.cpp:244
> - int marginSize = extendBackground ? 512 : 0;
> + int marginSize = hasExtendedBackgroundRect ? 512 : 0;
What is the magical 512? Could you make it a constant with informative name?
More information about the webkit-reviews
mailing list