[webkit-reviews] review granted: [Bug 127412] [iOS] Upstream changes in Tools/DumpRenderTree : [Attachment 222124] [iOS] Upstream changes in Tools/DumpRenderTree

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 127412: [iOS] Upstream changes in Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=127412

Attachment 222124: [iOS] Upstream changes in Tools/DumpRenderTree
https://bugs.webkit.org/attachment.cgi?id=222124&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222124&action=review


> Tools/DumpRenderTree/AccessibilityTextMarker.h:61
> +#if PLATFORM(MAC) && SUPPORTS_AX_TEXTMARKERS

Don't think you need the PLATFORM(MAC) here any more.

> Tools/DumpRenderTree/AccessibilityTextMarker.h:81
> +#if PLATFORM(MAC) && SUPPORTS_AX_TEXTMARKERS

Ditto.

> Tools/DumpRenderTree/ios/Info.plist:12
> +	<string>com.apple.DumpRenderTree</string>

org.webkit?

>
Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:1
> +# Copyright (C) 2009 Apple Inc. All rights reserved.

2014?

>
Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimu
latorNotification.pm:1
> +# Copyright (C) 2009 Apple Inc. All rights reserved.

2014?

> Tools/DumpRenderTree/ios/PerlSupport/Makefile:1
> +# Copyright (C) 2009 Apple Inc. All rights reserved.

2014

> Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:2
> + * Copyright (C) 2005, 2006, 2007, 2009 Apple Inc. All rights reserved.

2014

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:762
> +    // See also -[TabDocument _updateTextSize] in MobileSafari/TabDocument.m


Remove this comment.

> Tools/DumpRenderTree/mac/EventSendingController.mm:423
> +#if !PLATFORM(IOS)
>	   flags |= NSControlKeyMask;
> +#else
> +	   flags |= WebEventFlagMaskControl;
> +#endif

These are ugly. Can we just make some common #ifdefs or an enum?

> Tools/DumpRenderTree/mac/ObjCPlugin.m:133
> +#if PLATFORM(IOS)
> +    return NSStringFromClass([obj class]);
> +#else
>      return [obj className];
> +#endif

No idea why this is different.