[webkit-reviews] review denied: [Bug 127566] fast/profiler tests ASSERTing after moving recompileAllJSFunctions off a timer : [Attachment 222131] [PATCH] Proposed Fix - Let the VM manage recompilation

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 127566: fast/profiler tests ASSERTing after moving recompileAllJSFunctions
off a timer
https://bugs.webkit.org/show_bug.cgi?id=127566

Attachment 222131: [PATCH] Proposed Fix - Let the VM manage recompilation
https://bugs.webkit.org/attachment.cgi?id=222131&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222131&action=review


> Source/JavaScriptCore/runtime/VMEntryScope.cpp:66
> +    if (UNLIKELY(m_recompilationNeeded)) {

You can't do this unless .entryScope is null.  Otherwise you have to set the
parent's entry scope recompile flag.