[webkit-reviews] review denied: [Bug 72948] resize:both does not respect min-width and max-width : [Attachment 221838] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied gur.trio at gmail.com's
request for review:
Bug 72948: resize:both does not respect min-width and max-width
https://bugs.webkit.org/show_bug.cgi?id=72948

Attachment 221838: Patch
https://bugs.webkit.org/attachment.cgi?id=221838&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221838&action=review


> Source/WebCore/rendering/RenderLayer.cpp:2633
> +    if (renderer->style().minWidth().isPercent())
> +	   minWidth = renderer->style().minWidth().percent() / 100 *
renderer->parent()->absoluteBoundingBoxRect().width();
> +    if (renderer->style().minHeight().isPercent())
> +	   minHeight = renderer->style().minHeight().percent() / 100 *
renderer->parent()->absoluteBoundingBoxRect().height();

This is the wrong way to resolve percentages etc. You should look at the code
that use min/maxWidth to do layout.