[webkit-reviews] review granted: [Bug 125006] [curl] Improve detecting and handling of SSL client certificate : [Attachment 221843] proposed patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted sipka at inf.u-szeged.hu's request
for review:
Bug 125006: [curl] Improve detecting and handling of SSL client certificate
https://bugs.webkit.org/show_bug.cgi?id=125006

Attachment 221843: proposed patch
https://bugs.webkit.org/attachment.cgi?id=221843&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221843&action=review


Thanks for revising!  Looks great.

> Source/WebCore/platform/network/curl/SSLHandle.cpp:59
> +    HashMap<String, clientCertificate>::iterator it =
allowedClientHosts.find(host.lower());

In the future, consider using auto. I think this could be a const_iterator, or
even better "const auto& it = ..."