[webkit-reviews] review granted: [Bug 127204] Silence a warning emitted when preprocessing mediaControlsApple.js : [Attachment 221509] Silence a warning emitted when preprocessing mediaControlsApple.js

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 127204: Silence a warning emitted when preprocessing mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=127204

Attachment 221509: Silence a warning emitted when preprocessing
mediaControlsApple.js
https://bugs.webkit.org/attachment.cgi?id=221509&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221509&action=review


r=me, although my suggestion would be slightly cleaner if it works because we
can still use the JS file as-is during development.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:839
>	   return (time < 0 ? '-' : '' ) + String('00' + intMinutes).slice(-2)
+ ":" + String('00' + intSeconds).slice(-2)

I think you can also silence this warning by replacing the empty single-quotes
with double-quotes: '' -> ""