[webkit-reviews] review granted: [Bug 127201] CStack Branch: Fix Baseline JIT for X86-32 : [Attachment 221508] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 127201: CStack Branch: Fix Baseline JIT for X86-32
https://bugs.webkit.org/show_bug.cgi?id=127201

Attachment 221508: Patch
https://bugs.webkit.org/attachment.cgi?id=221508&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221508&action=review


r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   epilogues) and making room on the stack for outgoiing arguments.

Should be "outgoing".

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:523
> +    // Install the new return PC.
> +    // FIXME: I don't think currentReturnThunkPC is used and should be
deleted.
> +#  if 0
> +    jit.loadPtr(&vm->currentReturnThunkPC, GPRInfo::regT2);
> +    jit.storePtr(GPRInfo::regT2,
JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister,
CallFrame::returnPCOffset()));
> +#   else
> +    jit.storePtr(GPRInfo::regT5,
JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister,
CallFrame::returnPCOffset()));
> +#   endif

Need a bug about this.