[webkit-reviews] review granted: [Bug 126918] Identifier for sessions : [Attachment 221502] address comments

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Martin Hock <mhock at apple.com>'s
request for review:
Bug 126918: Identifier for sessions
https://bugs.webkit.org/show_bug.cgi?id=126918

Attachment 221502: address comments
https://bugs.webkit.org/attachment.cgi?id=221502&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221502&action=review


Looks good to me. Please fix failing builds (gtk-wk2 is red, it's a shame that
we are no longer informed about such failures immediately, and have to poll).

Please also run all tests in a local debug build.

> Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm:90
> +    SessionTracker::session(sessionID) =
std::move(NetworkStorageSession::createPrivateBrowsingSession(SessionTracker::g
etIdentifierBase() + '.' + String::number(sessionID)));

Is this std::move needed?

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:55
> +    SessionTracker::session(sessionID) =
std::move(NetworkStorageSession::createPrivateBrowsingSession(base + '.' +
String::number(sessionID)));

Is this std::move needed?