[webkit-reviews] review granted: [Bug 127202] Clean up PageCache classes : [Attachment 221506] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127202: Clean up PageCache classes
https://bugs.webkit.org/show_bug.cgi?id=127202

Attachment 221506: Patch
https://bugs.webkit.org/attachment.cgi?id=221506&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221506&action=review


k

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1414
> -    OwnPtr<WebCachedFramePlatformData> webPlatformData = adoptPtr(new
WebCachedFramePlatformData([m_webFrame->_private->webFrameView documentView]));

> -    cachedFrame->setCachedFramePlatformData(webPlatformData.release());
> +    auto webPlatformData =
std::make_unique<WebCachedFramePlatformData>(m_webFrame->_private->webFrameView
.documentView);
> +    cachedFrame->setCachedFramePlatformData(std::move(webPlatformData));

I'd get rid of the temporary here, since using it after this point would be an
error anyway.