[webkit-reviews] review granted: [Bug 126831] Web Inspector: Implement bar graph rendering for OverviewTimelineView : [Attachment 220952] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 126831: Web Inspector: Implement bar graph rendering for
OverviewTimelineView
https://bugs.webkit.org/show_bug.cgi?id=126831

Attachment 220952: Patch
https://bugs.webkit.org/attachment.cgi?id=220952&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220952&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineDataGridNode.js:98
> +	       } else {
> +		   timelineRecordBar.element.remove();
> +	       }

Style: Braces not needed.

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:86
> +	   // If this bar is completly after the current time, return early.

Typo: completly

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:90
> +	   // If this bar is completly before or after the bounds of the graph,
return early.

Typo: completly