[webkit-reviews] review granted: [Bug 127141] platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener : [Attachment 221478] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 17 11:49:14 PST 2014
Alexey Proskuryakov <ap at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 127141: platform/mac/accessibility/aria-multiline.html sometimes asserts in
AccessibilityController::removeNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=127141
Attachment 221478: patch
https://bugs.webkit.org/attachment.cgi?id=221478&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221478&action=review
r=me
> Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:126
> +{
> +}
Not needed on iOS?
> Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm:145
> + // No longer a need to cleanup for tests, since resetToConsistentState
will remove the listener.
Should we remove this function completely, including from all tests?
More information about the webkit-reviews
mailing list