[webkit-reviews] review granted: [Bug 127036] [EFL][WK2] Implement TestController::setHidden : [Attachment 221251] proposed patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 127036: [EFL][WK2] Implement TestController::setHidden
https://bugs.webkit.org/show_bug.cgi?id=127036

Attachment 221251: proposed patch
https://bugs.webkit.org/attachment.cgi?id=221251&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review


>> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110
>> +	if (!view)
> 
> Is there any possibility that platformView() is null ? Looks unneeded check.

I find a possibility platformView() can return null. It would be good if you
print a log when view is null.