[webkit-reviews] review granted: [Bug 126424] [EFL][WK2] Use timestamp when event occurs for touch events. : [Attachment 221322] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 15 20:04:37 PST 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 126424: [EFL][WK2] Use timestamp when event occurs for touch events.
https://bugs.webkit.org/show_bug.cgi?id=126424
Attachment 221322: Patch
https://bugs.webkit.org/attachment.cgi?id=221322&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221322&action=review
Looks better than before. r=me together with Ryuan informal review.
> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:781
> + evas_object_event_callback_add(m_evasObject,
EVAS_CALLBACK_MOUSE_DOWN, handleMouseDownForTouch, sd);
This function name change isn't mentioned in ChangeLog. It would be nicer if
you mention this change as well.
More information about the webkit-reviews
mailing list