[webkit-reviews] review granted: [Bug 126977] [GTK] UI process crashes when the web process crashes while printing : [Attachment 221147] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 14 06:51:15 PST 2014


Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126977: [GTK] UI process crashes when the web process crashes while
printing
https://bugs.webkit.org/show_bug.cgi?id=126977

Attachment 221147: Patch
https://bugs.webkit.org/attachment.cgi?id=221147&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221147&action=review


> Source/WebKit2/ChangeLog:9
> +	   invalidated, so that the function is called with a NULL error.

s/that //, the function being called with NULL is the consequence, not the
reason

> Tools/Scripts/run-gtk-tests:72
> +	   SkippedTest("WebKit2Gtk/TestPrinting",
"/webkit2/WebKitPrintOperation/close-after-print", "Test time times out",
126979),

s/time //g?


More information about the webkit-reviews mailing list