[webkit-reviews] review granted: [Bug 126133] Make CachedSVGDocument independent of CSS Filters : [Attachment 221144] Patch with style updates

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 126133: Make CachedSVGDocument independent of CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=126133

Attachment 221144: Patch with style updates
https://bugs.webkit.org/attachment.cgi?id=221144&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=221144&action=review


r=me

> Source/WebCore/css/StyleResolver.cpp:3433
> +    for (auto it = state.pendingSVGDocuments().begin(), end =
state.pendingSVGDocuments().end(); it != end; ++it)
> +	   (*it)->load(cachedResourceLoader);

Please use range-for syntax:

for (auto pendingDocument : state.pendingSVGDocuments())

> Source/WebCore/loader/cache/CachedSVGDocumentReference.h:44
> -    CachedSVGDocumentReference(CachedSVGDocument*);
> +    static std::unique_ptr<CachedSVGDocumentReference> create(const String&
url)
> +    {
> +	   return std::unique_ptr<CachedSVGDocumentReference>(new
CachedSVGDocumentReference(url));
> +    }

No need to add create(). Please just keep the constructor public and use
std::make_unique<CachedSVGDocumentReference>(url);