[webkit-reviews] review granted: [Bug 126508] [EFL] Merge ewk_view_single into ewk_view : [Attachment 220607] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 8 15:54:45 PST 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 126508: [EFL] Merge ewk_view_single into ewk_view
https://bugs.webkit.org/show_bug.cgi?id=126508
Attachment 220607: Patch
https://bugs.webkit.org/attachment.cgi?id=220607&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220607&action=review
Looks fine.
> Source/WebKit/efl/ewk/ewk_view.cpp:1415
> + Evas_Coord dx, dy, contentWidth, contentHeight;
It would be nicer if we use more readable name for dx, dy.
More information about the webkit-reviews
mailing list