[webkit-reviews] review granted: [Bug 126667] Web Inspector: Update the current WebInspector.TimelineView when time range changes : [Attachment 220671] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 126667: Web Inspector: Update the current WebInspector.TimelineView when
time range changes
https://bugs.webkit.org/show_bug.cgi?id=126667

Attachment 220671: Patch
https://bugs.webkit.org/attachment.cgi?id=220671&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220671&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineContentView.js:196
> +	   var endTime =
Math.max(WebInspector.timelineManager.recording.endTime || startTime,
startTime);

Hmm, this doesn't sound right. Maybe the "|| startTime" should just go away,
no?

> Source/WebInspectorUI/UserInterface/TimelineOverview.js:167
> +	   // Update all ruler element to the new required width.

Typo: "all ruler" => "ruler"

> Source/WebInspectorUI/UserInterface/TimelineView.js:169
> +	   this._scheduledLayoutUpdateIdentifier =
requestAnimationFrame(this.updateLayout.bind(this));

How often will we updateLayout? Maybe we should cache an
updateLayout.bind(this) to prevent function creation churn?