[webkit-reviews] review denied: [Bug 125770] [CSS Regions][CSS Shapes] ASSERTION FAILED: m_segmentRanges.size() < m_segments.size() : [Attachment 219345] Patch - address Darin's comment

[bugzilla-daemon at webkit.org]

Bem Jones-Bey <bjonesbe at adobe.com> has denied Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 125770: [CSS Regions][CSS Shapes] ASSERTION FAILED: m_segmentRanges.size()
< m_segments.size()
https://bugs.webkit.org/show_bug.cgi?id=125770

Attachment 219345: Patch - address Darin's comment
https://bugs.webkit.org/attachment.cgi?id=219345&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219345&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1226
> +	   // flows into the next region with a shape, we need to update the
current shape and region

This code seems like it belongs in the "overflowsToNextRegion" case above, as
it is very strange to have two different places in the same function that move
to the next region, and it also makes the code hard to follow. If it doesn't
make the patch too big, I would prefer if this is refactored to make that
possible. If not, then a FIXME comment here is ok, with a reference to a bug to
do the refactor.