[webkit-reviews] review granted: [Bug 126511] build.webkit.org/dashboard should still function if localStorage is disabled : [Attachment 220441] patch that hides the gear

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 126511: build.webkit.org/dashboard should still function if localStorage is
disabled
https://bugs.webkit.org/show_bug.cgi?id=126511

Attachment 220441: patch that hides the gear
https://bugs.webkit.org/attachment.cgi?id=220441&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220441&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/S
ettings.js:45
> +	   try {
> +	       localStorage.setItem(key, JSON.stringify(value));
> +	   } catch(e) {
> +	       console.log("Couldn't use localStorage, settings won't work: " +
e);
> +	   }

Do we need this try/catch now? Seems helpful to have breakage clearly visible.