[webkit-reviews] review granted: [Bug 126477] Simplify ScrollingStateNode references to various layer types : [Attachment 220359] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 126477: Simplify ScrollingStateNode references to various layer types
https://bugs.webkit.org/show_bug.cgi?id=126477

Attachment 220359: Patch
https://bugs.webkit.org/attachment.cgi?id=220359&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220359&action=review


> Source/WebCore/page/scrolling/ScrollingStateNode.h:119
> +	   return true;

assert_not_reached?

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:244
> +    scrollingStateTree().setHasChangedProperties(true);

I think I've asked this before; why doesn't setPropertyChanged do this?