[webkit-reviews] review granted: [Bug 126473] Simplify process suppression state calculation : [Attachment 220358] Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 126473: Simplify process suppression state calculation
https://bugs.webkit.org/show_bug.cgi?id=126473

Attachment 220358: Fix
https://bugs.webkit.org/attachment.cgi?id=220358&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220358&action=review


> ../OpenSource/Source/WebKit2/UIProcess/WebPageProxy.cpp:520
> +    return m_viewState & ViewState::IsVisuallyIdle &&
m_pageGroup->preferences()->pageVisibilityBasedProcessSuppressionEnabled();

Feels like this should have parens to indicate associativity.

> ../OpenSource/Source/WebKit2/UIProcess/mac/WebContextMac.mm:391
> +    for (const auto& context : WebContext::allContexts()) {

Why does this loop use "const auto&" while the other uses "auto*"?