[webkit-reviews] review denied: [Bug 126331] CStack: Refactor to split the tracking of the jsStackLimit from the native stackLimit. : [Attachment 220148] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 126331: CStack: Refactor to split the tracking of the jsStackLimit from the
native stackLimit.
https://bugs.webkit.org/show_bug.cgi?id=126331

Attachment 220148: the patch.
https://bugs.webkit.org/attachment.cgi?id=220148&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220148&action=review


> Source/JavaScriptCore/runtime/VMEntryScope.cpp:78
> +#if !ENABLE(LLINT_C_LOOP)
> +    void* jsStackLimit =
m_stack.recursionLimit(requiredCapacity(JSStackCapacity));
> +    m_vm.setJSStackLimit(jsStackLimit);
> +#endif

These #ifdefs look wrong. The JS stack limit is CLoop-only. Why does the #ifdef
say "*not* enable CLoop?"