[webkit-reviews] review granted: [Bug 126237] [iOS] Upstream WebCore/css changes : [Attachment 220010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 13:18:54 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 126237: [iOS] Upstream WebCore/css changes
https://bugs.webkit.org/show_bug.cgi?id=126237

Attachment 220010: Patch
https://bugs.webkit.org/attachment.cgi?id=220010&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220010&action=review


> Source/WebCore/css/DeprecatedStyleBuilder.cpp:2292
> +    // be float for sub-pixel kerning. See <rdar://problem/5020763>.

Wrong radar number?

Reference https://bugs.webkit.org/show_bug.cgi?id=20606 in the comment?

> Source/WebCore/css/MediaQueryEvaluator.cpp:635
> +    static wkDeviceClass deviceClass = iosDeviceClass();
> +    return deviceClass == wkDeviceClassiPhone || deviceClass ==
wkDeviceClassiPod;

Seems odd for this behavioral limitation to be hardcoded in WebCore. It should
be a client decision; maybe exposed via ChromeClient?


More information about the webkit-reviews mailing list