[webkit-reviews] review granted: [Bug 129182] [WebRTC] Validating RTCConfiguration according to the spec : [Attachment 224926] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 129182: [WebRTC] Validating RTCConfiguration according to the spec
https://bugs.webkit.org/show_bug.cgi?id=129182

Attachment 224926: Patch
https://bugs.webkit.org/attachment.cgi?id=224926&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224926&action=review


I might have missed it, but I don't see any new tests that pass a list of urls.


> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:83
> +    // Spec says that "urls" can be either a string or a sequence, so we
must check for both.
> +    Vector<String> urlsList;
> +    String urlString;

Nit: this can move down where the variables are used.