[webkit-reviews] review granted: [Bug 129166] [EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC : [Attachment 224925] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 129166: [EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=129166

Attachment 224925: Patch
https://bugs.webkit.org/attachment.cgi?id=224925&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224925&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC
.mm:67
> +    UNUSED_PARAM(errorCode);
> +    UNUSED_PARAM(systemCode);

Maybe you should set these out params to 0?

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC
.mm:110
> +    LOG(Media, "CDMSessionMediaSourceAVFObjC::update(%p) - key data", this);

> +    RetainPtr<NSData> keyData = adoptNS([[NSData alloc]
initWithBytes:key->data() length:key->length()]);
> +    [m_parent->parser() processContentKeyResponseData:keyData.get()
forTrackID:m_parent->protectedTrackID()];
> +    return true;

Ditto about errorCode and systemCode.