[webkit-reviews] review granted: [Bug 128622] Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner : [Attachment 224906] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 128622: Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=128622

Attachment 224906: Patch
https://bugs.webkit.org/attachment.cgi?id=224906&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224906&action=review


I would suggesting doing the test result move in a separate commit from the
script changes.

> Tools/Scripts/old-run-webkit-tests:130
> -sub installAndLaunchDumpRenderTreeAppUsingNotification($$);
> +sub installAndLaunchDumpToolAppUsingNotification($$);

I think you could use "TestRunnerApp" as the generic term.