[webkit-reviews] review granted: [Bug 129169] gatherFromOtherThread() needs to align the sp before gathering roots : [Attachment 224905] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 129169: gatherFromOtherThread() needs to align the sp before gathering
roots
https://bugs.webkit.org/show_bug.cgi?id=129169

Attachment 224905: the patch.
https://bugs.webkit.org/attachment.cgi?id=224905&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224905&action=review


r=me

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:448
> +    stackPointer =
reinterpret_cast<void*>(WTF::roundUpToMultipleOf<sizeof(void*)>(reinterpret_cas
t<size_t>(stackPointer)));

Let's use uintptr_t instead of size_t.