[webkit-reviews] review granted: [Bug 128372] [CSS Grid Layout] handle undefined RemainingSpace in computeUsedBreadthOfGridTracks algorithm : [Attachment 223649] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 128372: [CSS Grid Layout] handle undefined RemainingSpace in
computeUsedBreadthOfGridTracks algorithm
https://bugs.webkit.org/show_bug.cgi?id=128372

Attachment 223649: Patch
https://bugs.webkit.org/attachment.cgi?id=223649&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223649&action=review


r=me, although concerned about the one function I called out.

> Source/WebCore/rendering/RenderGrid.cpp:269
> +static bool gridElementIsShrinkToFit(const RenderStyle& style)
> +{
> +    return style.isFloating() || style.position() == AbsolutePosition;
> +}

This looks suspicious to me. Are you wanting to catch everybody that just sizes
intrinsically? This is not enough if so.