[webkit-reviews] review granted: [Bug 128897] Move inheriting method to the superclass in the JavaScript media controls : [Attachment 224350] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 17 08:36:35 PST 2014


Jer Noble <jer.noble at apple.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 128897: Move inheriting method to the superclass in the JavaScript media
controls
https://bugs.webkit.org/show_bug.cgi?id=128897

Attachment 224350: Patch
https://bugs.webkit.org/attachment.cgi?id=224350&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224350&action=review


> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
> +    inheritTo: function(child) {

I'm not a huge fan of "inheritTo()".  How about "extend()"?


More information about the webkit-reviews mailing list