[webkit-reviews] review denied: [Bug 128815] [CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box : [Attachment 224368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 17 08:28:44 PST 2014


Andrei Bucur <abucur at adobe.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 128815: [CSS Regions] The box decorations of an element overflowing a
region should be clipped at the border box, not the content box
https://bugs.webkit.org/show_bug.cgi?id=128815

Attachment 224368: Patch
https://bugs.webkit.org/attachment.cgi?id=224368&action=review

------- Additional Comments from Andrei Bucur <abucur at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224368&action=review


> Source/WebCore/rendering/RenderRegion.cpp:525
>	   mappedRect.intersect(flowThreadPortionRect());

I think the correct order of operations is to expand the
flowThreadPortionRect() with the paddings and then intersect. This way:
1. You expand only when actually clipping
2. You don't expand a rectangle already intersected with the
flowThreadPortionRect() that doesn't need the extra space to display correctly.


> Source/WebCore/rendering/RenderRegion.cpp:533
> +	   if (isFirstRegion()) {

This should be startRegion.

> Source/WebCore/rendering/RenderRegion.cpp:543
> +	   if (isLastRegion()) {

This should be lastRegion.


More information about the webkit-reviews mailing list