[webkit-reviews] review granted: [Bug 128284] Support encoding and decoding of Regions : [Attachment 223281] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 5 18:01:24 PST 2014
Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 128284: Support encoding and decoding of Regions
https://bugs.webkit.org/show_bug.cgi?id=128284
Attachment 223281: Patch
https://bugs.webkit.org/attachment.cgi?id=223281&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223281&action=review
> Source/WebCore/platform/graphics/Region.cpp:336
> + for (Shape::SpanIterator span = spans_begin(), end = spans_end(); span
!= end && span + 1 != end; ++span) {
auto span
> Source/WebCore/platform/graphics/Region.cpp:343
> + for (Shape::SegmentIterator segment = segments_begin(span), end =
segments_end(span); segment != end && segment + 1 != end; segment += 2) {
auto segment
> Source/WebCore/platform/graphics/Region.h:75
> + { }
Should be newline:
{
}
> Source/WebCore/platform/graphics/Region.h:79
> + { }
Newline
{
}
More information about the webkit-reviews
mailing list