[webkit-reviews] review granted: [Bug 70592] [EFL][GTK] Share plugin's implementation between EFL and Gtk ports. : [Attachment 221111] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 70592: [EFL][GTK] Share plugin's implementation between EFL and Gtk ports.
https://bugs.webkit.org/show_bug.cgi?id=70592

Attachment 221111: Patch
https://bugs.webkit.org/attachment.cgi?id=221111&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221111&action=review


I believe this is a way to go between efl and gtk. r+ed by me on behalf of gtk
reviewer. Please fix trivial nits before landing.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:309
> +    // TODO remove in favor of null events, like mac port?

TODO -> FIXME: ?

> Source/WebCore/plugins/x11/PluginViewX11.cpp:135
> +    // TODO: optimize

ditto.