[webkit-reviews] review granted: [Bug 136248] [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API : [Attachment 237143] Fix coding style issues

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136248: [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=136248

Attachment 237143: Fix coding style issues
https://bugs.webkit.org/attachment.cgi?id=237143&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237143&action=review


LGTM

>>> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:280
>>> +	 if (!response->priv->resourceResponse.url().protocolIsInHTTPFamily())
>> 
>> Shouldn't this check be done before the previous one?
> 
> I don't think so, once we have a valid pointer we should return that one, no
need to check again it's an HTTP response

The detail Sergio may have missed is that httpHeaders is only there if the
resposts was for a protocal in the HTTP family. This check protects against
creating httpHeaders in the first place (below).