[webkit-reviews] review granted: [Bug 136333] AX: Safari at com.apple.WebCore: WebCore::AXObjectCache::clearTextMarkerNodesInUse : [Attachment 237294] patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 136333: AX: Safari at com.apple.WebCore:
WebCore::AXObjectCache::clearTextMarkerNodesInUse
https://bugs.webkit.org/show_bug.cgi?id=136333

Attachment 237294: patch
https://bugs.webkit.org/attachment.cgi?id=237294&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237294&action=review


r=me but please consider the comment below.

> Source/WebCore/accessibility/AXObjectCache.cpp:1051
> +	   if (node->inDocument() && &(node)->document() == document)

Is there a reason to keep nodes not in a document in m_textMarkerNodes?  Just
wondering if this condition should be || instead of && (and negated) since we
might build up document-less nodes in the cache over time with the !document
early return above:

	If (!node->inDocument() || &node->document() == document)