[webkit-reviews] review granted: [Bug 135978] Turn r/rx/ry to presentation attributes : [Attachment 236650] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 135978: Turn r/rx/ry to presentation attributes
https://bugs.webkit.org/show_bug.cgi?id=135978

Attachment 236650: Patch
https://bugs.webkit.org/attachment.cgi?id=236650&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236650&action=review


It seems this has much of the original cx/cy patch in it. Assuming that is
removed when the cx/cy lands... r=me

> Source/WebCore/ChangeLog:64
> +2014-08-15  Dirk Schulze  <krit at webkit.org>
> +
> +	   Turn cx/cy to presentation attributes
> +	   https://bugs.webkit.org/show_bug.cgi?id=135975
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   This follows the patch for width and height presentation attributes
and
> +	   turns x and y to presentation attributes as well:
> +

ChangeLog has the previous patch in it as well.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:408
> +    CSSPropertyCx,
> +    CSSPropertyCy,

Oops.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2977
> +	   case CSSPropertyCx:
> +	       return zoomAdjustedPixelValueForLength(style->svgStyle().cx(),
style.get());
> +	   case CSSPropertyCy:
> +	       return zoomAdjustedPixelValueForLength(style->svgStyle().cy(),
style.get());

Oops.

> LayoutTests/ChangeLog:22
> +2014-08-15  Dirk Schulze  <krit at webkit.org>
> +
> +	   Turn cx/cy to presentation attributes
> +	   https://bugs.webkit.org/show_bug.cgi?id=135975
> +
> +	   Reviewed by NOBODY (OOPS!).

More Oops.